Skip to content

Conversation

@joaquim-verges
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:09am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:09am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:09am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:09am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 1:09am

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2025

🦋 Changeset detected

Latest commit: c0034e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Minor
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Apr 28, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title [SDK] Add enclave wallet message signing and minimal account implementation [WIP][SDK] Add minimal account implementation Apr 28, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review April 28, 2025 11:26
@joaquim-verges joaquim-verges requested review from a team and jnsdls as code owners April 28, 2025 11:26
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.12 KB (+0.66% 🔺) 1.1 s (+0.66% 🔺) 216 ms (+120.6% 🔺) 1.3 s
thirdweb (cjs) 193.8 KB (+34.35% 🔺) 3.9 s (+34.35% 🔺) 514 ms (+84.49% 🔺) 4.4 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 103 ms (+1038.21% 🔺) 217 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 31 ms (+955.56% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (+0.25% 🔺) 391 ms (+0.25% 🔺) 81 ms (+402.5% 🔺) 472 ms

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.59%. Comparing base (4e6daac) to head (c0034e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6874      +/-   ##
==========================================
- Coverage   54.81%   54.59%   -0.23%     
==========================================
  Files         901      903       +2     
  Lines       57610    57930     +320     
  Branches     3961     3968       +7     
==========================================
+ Hits        31580    31627      +47     
- Misses      25930    26202     +272     
- Partials      100      101       +1     
Flag Coverage Δ
packages 54.59% <100.00%> (-0.23%) ⬇️
Files with missing lines Coverage Δ
...kages/thirdweb/src/contract/actions/resolve-abi.ts 89.52% <100.00%> (+0.16%) ⬆️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges force-pushed the _SDK_Add_enclave_wallet_message_signing_and_minimal_account_implementation branch from d806add to c0034e6 Compare May 8, 2025 00:59
@joaquim-verges joaquim-verges merged commit e96ebba into main May 8, 2025
23 of 24 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_Add_enclave_wallet_message_signing_and_minimal_account_implementation branch May 8, 2025 01:09
@joaquim-verges joaquim-verges mentioned this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants